Please consider implementing a unit test for this func.

added unit test

Same here

added unit test

Don't know if you are aware of this, please don't forget to implement the import.

You can ensure this by adding the code below:

// Ensure the implementation satisfies the expected interfaces.
var (
	_ resource.Resource                 = &keyRingResource{}
	_ resource.ResourceWithConfigure    = &keyRingResource{}
	_ resource.ResourceWithImportState  = &keyRingResource{}
)

See the git instance resource how to do it:

Consider doing the same for the datasource, see the git instance datasource for example:

https://github.com/stackitcloud/terraform-provider-stackit/blob/main/stackit/internal/services/git/instance/datasource.go#L24-L27

done

updated

According to https://docs.api.stackit.cloud/documentation/kms/version/v1beta , the KMS API already uses the new multi-region concept.

See e.g. the stackit_routing_table resource how to implement the multi-region concept. The resource has a region field which is marked as optional and will use the default_region configured in the provider as a fallback: https://registry.terraform.io/providers/stackitcloud/stackit/latest/docs/resources/routing_table

• You will need to store the provider configuration within your resource struct:

  terraform-provider-stackit/stackit/internal/services/iaasalpha/routingtable/table/resource.go

  Line 63 in 8e77675

  providerData core.ProviderData

  and

  terraform-provider-stackit/stackit/internal/services/iaasalpha/routingtable/table/resource.go

  Lines 73 to 77 in 8e77675

  	var ok bool
  	r.providerData, ok = conversion.ParseProviderData(ctx, req.ProviderData, &resp.Diagnostics)
  	if !ok {
  	return
  	}

• Field definition:

  terraform-provider-stackit/stackit/internal/services/iaasalpha/routingtable/table/resource.go

  Lines 161 to 169 in 8e77675

  	"region": schema.StringAttribute{
  	Optional: true,
  	// must be computed to allow for storing the override value from the provider
  	Computed: true,
  	Description: "The resource region. If not defined, the provider region is used.",
  	PlanModifiers: []planmodifier.String{
  	stringplanmodifier.RequiresReplace(),
  	},
  	},

• Then use this helper func to read the region:

  terraform-provider-stackit/stackit/internal/services/iaasalpha/routingtable/table/resource.go

  Line 203 in 8e77675

  region := r.providerData.GetRegionWithOverride(model.Region)

updated region logic

Since the KMS API already implemented the new multi-region concept, you don't need to set the region here (or better: the SDK should throw an error if you do 😄 ).

Apart from that, consider adding a unit tests for this func, see e.g. https://github.com/stackitcloud/terraform-provider-stackit/blob/8e776757ea2280d1222afe50c3024945b4d99eed/stackit/internal/services/git/utils/util_test.go

updated

In all three data sources the examples are missing. Please add them in examples/data-sources/<data-source-name>/data-source.tf like you did it for the resources

We usually have the project_id and depending ids, like in this case key_ring_id at the top of the example. And for the basic example we only set the required fields.

If you want you can also add an additional example, where the stackit_kms_key resource is used together with stackit_kms_key_ring, but this is not necessary. If you add it, please add a comment to indicate, that it's a different example

Description of import_only doesn't fit here. And based on the api spec, it's only an optional field

Regarding the api spec access_scope is missing

I think with the migration from v1beta -> v1, this was renamed to protection

Add an example how the resource can be imported, like we have it here

Change also the order here, so that project_id is first and remove region_id. Also add an import example

Change the order, so that project_id and key_ring_id are first. And add an import example

It's probably our fault that this is quite old, but this can be update to v1.0.0. You should then get the change for backend -> protection and the new field access_scope.

Please try to avoid upgrading other modules than the one that are required for you PR. I think most of them should be already in our main branch, so a rebase would probably fix this :)

Only a nitpick and most of our datasources are also missing this. But this ensures that the Configure method is implemented correct

you can also check the region and project_id this way btw (even if you don't set them manually in the Min test and use the fallback values from the provider config instead) to make sure the datasource and the resource return the same values

Please add resource.ResourceWithModifyPlan here.

Then make sure to implement ModifyPlan properly so the region field works properly in case the default_region in the provider configuration is updated.

Please also make sure to do this for all of your resources within this PR 😊